accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From billierinaldi <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
Date Mon, 24 Aug 2015 18:22:58 GMT
Github user billierinaldi commented on the pull request:

    https://github.com/apache/accumulo/pull/44#issuecomment-134325576
  
    This looks great.  Thanks, Dylan!  I have two suggestions.  One is about the sentence,
"Span entries record full span information, whereas index and start time entries provide indexing
into span information useful for quickly finding spans by type or start time."  Actually both
the span and start time entries have the full span information, while only the index entries
provide indexing.
    
    The other suggestion is to mention other configuration properties that would need to be
set for the zipkin span receiver in accumulo-site.xml and in the client configuration, such
as:
    ```
    <property>
      <name>trace.span.receiver.zipkin.collector-hostname</name>
      <value>localhost</value>
    </property>
    <property>
      <name>trace.span.receiver.zipkin.collector-port</name>
      <value>9410</value>
    </property>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message