accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: Implementation of SeekingFilter, CfCqSliceF...
Date Mon, 17 Aug 2015 16:36:15 GMT
Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/42#issuecomment-131883366
  
    :+1: this looks really good, Russ! Left a couple of comments in the code, but they were
mainly stylistic than issues. I would love to also see an integration test that uses this
iterator in a "real" environment, but that can be done as a follow-on. Your unit tests exercise
this code very well already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message