accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3920 Deprecate mock components
Date Thu, 09 Jul 2015 02:14:22 GMT
GitHub user ctubbsii opened a pull request:

    https://github.com/apache/accumulo/pull/40

    ACCUMULO-3920 Deprecate mock components

    == Done so far ==
    
    * Deprecate Accumulo Mock classes
    * Add javadoc to mock package to add additional details
    * Create `DeprecationUtil` to help migrate code which must continue to use mock
    * Minimize mock usage throughout the tests wherever possible
      * Use `EasyMock` in a few cases where it was possible to satisfy the test
      * Apply `@Rule`, `@Before`, etc. to reduce number of calls to `MockInstance`
    * Create replacement `IteratorAdapter` for use outside of mock
    
    == Could use help with ==
    (most of these can be pretty readily identified in Eclipse with deprecation warnings shown)
    * Migrating `FormatterCommandTest.java` to avoid use of `MockShell`
    * Migrating MapReduce tests and other "heavyweight" tests to use `MiniAccumuloCluster`
    * Migrating other "lightweight" tests to use `EasyMock`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ctubbsii/accumulo ACCUMULO-3920

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit 048f56cf6340dbcee5eec154753734bebe3bc45f
Author: Christopher Tubbs <ctubbsii@apache.org>
Date:   2015-07-09T02:02:03Z

    ACCUMULO-3920 Deprecate mock components
    
    * Deprecate Accumulo Mock classes
    * Add javadoc to mock package to add additional details
    * Create DeprecationUtil to help migrate code which must continue to use mock
    * Minimize mock usage throughout the tests wherever possible
      * Use EasyMock in a few cases where it was possible to satisfy the test
      * Apply @Rule, @Before, etc. to reduce number of calls to MockInstance
    * Create replacement IteratorAdapter for use outside of mock

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message