accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3920 Deprecate mock components
Date Mon, 13 Jul 2015 14:13:42 GMT
Github user keith-turner commented on the pull request:

    https://github.com/apache/accumulo/pull/40#issuecomment-120941438
  
    I am thinking we can drop `IntersectingIteratorTest.testWithBatchScanner()` because `ExamplesIT.testShardedIndex()`
will test IntersectingIter using a real batch scanner in an IT.  `IntersectingIteratorTest.testWithBatchScanner()`
is testing IntersectingIter using the mock batch scanner.  Alternatively if we want to treat
this as a test of mock, we could just suppress warnings on the test and add a comment stating
the test is intended to test the mock batch scanner.   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message