accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 36186: ACCUMULO-3840 Replace OpTImer to remove direct log4j dependencies
Date Mon, 06 Jul 2015 17:44:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36186/#review90507
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/util/EventTimer.java (line 46)
<https://reviews.apache.org/r/36186/#comment143627>

    Could also add a `@throws IllegalStateException ...`, but it's not a requirement. Up to
you.


- Josh Elser


On July 5, 2015, 11:39 a.m., Ed Coleman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36186/
> -----------------------------------------------------------
> 
> (Updated July 5, 2015, 11:39 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> As part of the removal of direct log4j dependecies - replaced OpTimer
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java c5cb482 
>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java
b087c73 
>   core/src/main/java/org/apache/accumulo/core/client/impl/RootTabletLocator.java 3a0c0d7

>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java 6f9ea29

>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletLocatorImpl.java c28320d

>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java
f263581 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java 5437cc4

>   core/src/main/java/org/apache/accumulo/core/metadata/MetadataLocationObtainer.java
0d294b8 
>   core/src/main/java/org/apache/accumulo/core/util/EventTimer.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/util/OpTimer.java 564a824 
>   core/src/test/java/org/apache/accumulo/core/util/EventTimerTest.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/client/HdfsZooInstance.java 0d7aaf1

>   test/src/main/java/org/apache/accumulo/test/NativeMapStressTest.java 72831d8 
> 
> Diff: https://reviews.apache.org/r/36186/diff/
> 
> 
> Testing
> -------
> 
> passes
> 
> mvn verify -DskipITs
> mvn package -P assemble
> 
> 
> Thanks,
> 
> Ed Coleman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message