Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C86518356 for ; Fri, 12 Jun 2015 22:03:09 +0000 (UTC) Received: (qmail 92134 invoked by uid 500); 12 Jun 2015 22:03:09 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 92097 invoked by uid 500); 12 Jun 2015 22:03:09 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 92086 invoked by uid 99); 12 Jun 2015 22:03:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jun 2015 22:03:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 24E65DFF09; Fri, 12 Jun 2015 22:03:09 +0000 (UTC) From: keith-turner To: dev@accumulo.apache.org Reply-To: dev@accumulo.apache.org Message-ID: Subject: [GitHub] accumulo pull request: ACCUMULO-2388 Make clients retry in case of... Content-Type: text/plain Date: Fri, 12 Jun 2015 22:03:09 +0000 (UTC) GitHub user keith-turner opened a pull request: https://github.com/apache/accumulo/pull/38 ACCUMULO-2388 Make clients retry in case of HoldTimeoutException To test this patch, I made the following changes and ran the WriteLotsIt and ConditionalWriterIT ``` diff --git a/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java b/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java index 7c0eedc..4483fe8 100644 --- a/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java +++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java @@ -469,6 +469,9 @@ public class TabletServerResourceManager { } void waitUntilCommitsAreEnabled() { + if(Math.random() < .1) + throw new HoldTimeoutException("test"); + if (holdCommits) { long timeout = System.currentTimeMillis() + conf.getConfiguration().getTimeInMillis(Property.GENERAL_RPC_TIMEOUT); synchronized (commitHold) { ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/keith-turner/accumulo ACCUMULO-2388 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/accumulo/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 ---- commit 6965fb07c97cd752d6f5415a39e87b9ff3c1ba7e Author: Keith Turner Date: 2015-06-12T21:47:18Z ACCUMULO-2388 Make clients retry in case of HoldTimeoutException ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---