accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3000: Added config option and impl...
Date Wed, 13 May 2015 20:04:28 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r30269956
  
    --- Diff: .gitignore ---
    @@ -23,3 +23,4 @@
     /.pydevproject
     /.idea
     /*.iml
    +*.swp
    --- End diff --
    
    The reason is that when you switch branches in git, it leaves behind ignored files. So,
we've stopped doing global ignores, and instead have been doing "rooted" ignores (I don't
know if that's the official term... it's just what I'm calling ignore expressions beginning
with "/"). That way, when you switch branches, you can see what was left behind (most frequently,
"target/" directories from previous builds for modules which exist in another branch, but
not the current one). This allows you to do more targeted `git clean` executions with `git
clean -fd` instead of needing to do `git clean -fdx`.
    
    If we do global ignores (with the prefixing "/"), some maven plugins (assembly, rat, etc.)
may treat those extra files as source files, because they don't exist in a current module's
"target/" directory (other source directories could, after all, also use the name "target").
    
    Keeping the `.gitignore` files rooted to each module helps us avoid ignoring files which
could be problematic if ignored globally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message