accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3000: Added config option and impl...
Date Wed, 13 May 2015 19:47:16 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r30268333
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
---
    @@ -93,6 +94,7 @@ private static void printProperties() {
         System.out.println("#" + TSERVER_MEMORY_PROP + "=128M");
         System.out.println("#" + ZOO_KEEPER_MEMORY_PROP + "=128M");
         System.out.println("#" + JDWP_ENABLED_PROP + "=false");
    +    System.out.println("#" + EXISTING_ZOO_KEEPERS_PROP + "=localhost:2181");
    --- End diff --
    
    I realize you were probably just following what was there, but does it make sense to print
these *before* the configuration options are parsed and set?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message