accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3000: Added config option and impl...
Date Wed, 13 May 2015 03:33:33 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r30200397
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
---
    @@ -75,6 +75,7 @@
       private static final String NUM_T_SERVERS_PROP = "numTServers";
       private static final String DIRECTORY_PROP = "directory";
       private static final String INSTANCE_NAME_PROP = "instanceName";
    +  private static final String EXISTING_ZOO_KEEPERS_PROP = "existingZooKeepers";
    --- End diff --
    
    Did we already address the addition here? MiniAccumuloRunner is also public API (like
MiniAccumuloCluster). Seems odd to add it here. I don't think we have a good way to hide it
though (like the MiniAccumuloClusterImpl), so maybe it's ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message