accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3771 Configure automatic java code...
Date Wed, 06 May 2015 15:47:45 GMT
Github user mikewalch commented on the pull request:

    https://github.com/apache/accumulo/pull/35#issuecomment-99519198
  
    I just pushed an updated PR with following changes:
    
    * Modified the configuration of the maven-java-formatter-plugin in `pom.xml` to use a
newer version (3.10) of the eclipse.jdt.core.  This reduced but did not eliminate the number
of trailing whitespace changes.   The number of files changed by the formatter was reduced
from the 550 to 170.
    * I agree with Christoper about the formatter.  It mostly removes whitespace.  The only
place where it adds whitespace is in block comments.  To get checkstyle work, I modified the
"Trailing whitespace" checkstyle rule ignore whitespace after an asterisk `*`.
    * Excluded thrift and proto buffer files in the formatter plugin configuration
    
    I reviewed all of the files that were changed after running the formatter.  While they
look good to me, feel free to comment on any formatting that should remain and I can add `//
@formatter:off` comments to those sections of the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message