Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Received-SPF: pass (nike.apache.org: local policy)
From: "THORMAN, ROBERT D" <rt2357@att.com>
To: "<dev@accumulo.apache.org>" <dev@accumulo.apache.org>
Subject: Re: Review Request 33085: ACCUMULO-3652 Refactor for slf4j with
 concatenated strings
Thread-Topic: Review Request 33085: ACCUMULO-3652 Refactor for slf4j with
 concatenated strings
Thread-Index: 
 AQHQc6pxtAiFvA7nFEeSvujacCtd251GxR4AgAA8nAD//6z0xYAAc/WA//+z/nuAAFV9gP//rTwJ
Date: Fri, 10 Apr 2015 22:47:37 +0000
Message-ID: <C28D344A-E5FF-4AD4-8858-2143C6E63E2F@att.com>
References: 
 <20150410163512.1488.21866@reviews.apache.org>,<20150410201208.1489.32782@reviews.apache.org>
 <2A012680-FB18-43A0-BC19-00CC654688D1@att.com>,<55284A33.8080303@gmail.com>
 <639A3ED0-3BF3-49DD-84EA-E881E3A1F36A@att.com>,<55285227.7080602@gmail.com>
In-Reply-To: <55285227.7080602@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Is there guidance for testing? I'd like to do more to help test for a relea=
se.=20

Sent from my iPhone

> On Apr 10, 2015, at 5:45 PM, Josh Elser <josh.elser@gmail.com> wrote:
>=20
> You already are a contributor. You have contributed code to the project :=
)
>=20
> THORMAN, ROBERT D wrote:
>> How does someone become a contributor?
>>=20
>> Sent from my iPhone
>>=20
>>> On Apr 10, 2015, at 5:12 PM, Josh Elser<josh.elser@gmail.com>  wrote:
>>>=20
>>> You don't get permissions to push to Apache as a contributor. This is s=
omething that committers have.
>>>=20
>>> You can open a pull request via Github apache/accumulo by forking that =
repository into your own account.
>>>=20
>>> THORMAN, ROBERT D wrote:
>>>> I'd like to do a pull request also but I don't have credentials to pus=
h my branch to the git repo.
>>>>=20
>>>> Sent from my iPhone
>>>>=20
>>>> On Apr 10, 2015, at 3:12 PM, Christopher Tubbs<ctubbsii-rb@apache.org<=
mailto:ctubbsii-rb@apache.org>>   wrote:
>>>>=20
>>>> This is an automatically generated e-mail. To reply, visit: https://re=
views.apache.org/r/33085/
>>>>=20
>>>>=20
>>>> On April 10th, 2015, 12:35 p.m. EDT, Mike Drob wrote:
>>>>=20
>>>> I think there's more in this review than just the log statements. I se=
e changes for adding guava Predicate, which makes me think your branch poin=
t got screwed up somewhere.
>>>>=20
>>>> On April 10th, 2015, 12:44 p.m. EDT, Bob Thorman wrote:
>>>>=20
>>>> Yeah, I'm using review board for the first time here.  I did a 'git de=
scribe ACCUMULO-3652' and the used the revision number to do a 'rbt post<re=
vision>'.  I had already merged with master and created my patch so that is=
 probably why all the other changes are included.  I tried to use 'git diff=
' but the file would not upload.
>>>>=20
>>>> On April 10th, 2015, 1:16 p.m. EDT, Bob Thorman wrote:
>>>>=20
>>>> I tried 'git diff --full-index ACCUMULO-3652 origin/master>   ACCUMULO=
-3652.diff' and then tried to update the diff in reviewboard but got the fo=
llowing error.
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>> error: unable to find 2fca41a0286b711c5d95e0fe544378230053e9ae fatal: =
git cat-file 2fca41a0
>>>>=20
>>>> On April 10th, 2015, 1:17 p.m. EDT, Bob Thorman wrote:
>>>>=20
>>>> I haven't pushed my branch back to the repo.  Is that required for rev=
iewboard?
>>>>=20
>>>> On April 10th, 2015, 1:28 p.m. EDT, Christopher Tubbs wrote:
>>>>=20
>>>> Try rebasing your patch, before creating the review. I've found the rb=
t tools to be quite poorly documented, so I haven't successfully used them =
myself. You could try just attaching your patch manually in the web interfa=
ce. That's what seems to have worked best for me in the past.
>>>>=20
>>>> On April 10th, 2015, 2:26 p.m. EDT, Bob Thorman wrote:
>>>>=20
>>>> I tried uploading the patch after rebaseing the branch but still got a=
n error.  I think both of these approaches are expecting to access my revis=
ion in the git repot as the following error seems to indicate.
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>> The file "server/tracer/src/main/java/org/apache/accumulo/tracer/Async=
SpanReceiver.java" (revision fc55de6) was not found in the repository
>>>>=20
>>>> On April 10th, 2015, 3:36 p.m. EDT, Josh Elser wrote:
>>>>=20
>>>> Looks like rbt might have done weird stuff to the review. Set the bran=
ch to be "master" and then try applying your patch
>>>>=20
>>>> ReviewBoard might keep some confusing state, too, so it'd probably be =
best to close this review, and create a fresh, new one. Don't forget, pull =
requests are an option, too, if you're more comfortable with that (though, =
obviously, there's value in learning another tool, too).
>>>>=20
>>>>=20
>>>> - Christopher
>>>>=20
>>>>=20
>>>> On April 10th, 2015, 12:21 p.m. EDT, Bob Thorman wrote:
>>>>=20
>>>> Review request for accumulo.
>>>> By Bob Thorman.
>>>>=20
>>>> Updated April 10, 2015, 12:21 p.m.
>>>>=20
>>>> Repository: accumulo
>>>> Description
>>>>=20
>>>> * Replace internal PropertyFilter with Guava's Predicate.
>>>> * Preserve MockConfiguration public API by deprecating PropertyFilter
>>>>=20
>>>> ACCUMULO-3719 Add StrictHostKeyChecking=3Dno to default SSH options
>>>>=20
>>>> For testing purposes, strict host key verification is probably
>>>> overkill. Disable it by default. Users can still override
>>>> this on their own if they are concerned about security implications.
>>>>=20
>>>> Merge branch '1.6'
>>>>=20
>>>>=20
>>>> Merge remote-tracking branch 'github/ACCUMULO-3714'
>>>>=20
>>>>=20
>>>> ACCUMULO-2131 while statement used as if statement. Changed the while =
to an if.
>>>>=20
>>>> Signed-off-by: Christopher Tubbs<ctubbsii@apache.org<mailto:ctubbsii@a=
pache.org>>
>>>>=20
>>>> ACCUMULO-3718 make Mutation#hashCode and Mutation#equals not change th=
e state of the mutation
>>>>=20
>>>>=20
>>>> Merge branch '1.5' into 1.6
>>>>=20
>>>>=20
>>>> Merge branch '1.6'
>>>>=20
>>>>=20
>>>> Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/accum=
ulo into ACCUMULO-3652
>>>>=20
>>>>=20
>>>> Diffs
>>>>=20
>>>>   *   core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java =
(6185419f0f0913b7a875cbdc608339881f4e77dd)
>>>>   *   core/src/main/java/org/apache/accumulo/core/client/impl/ClientCo=
ntext.java (9257a1ffbd0e216953c687949d16a6bfe2a41e3c)
>>>>   *   core/src/main/java/org/apache/accumulo/core/client/mock/MockConf=
iguration.java (8c57c5e6c2868d10e73b41cbb1b1f94fc64eb4b5)
>>>>   *   core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfigu=
ration.java (14d68c203497ea541db61c59562b004372aed085)
>>>>   *   core/src/main/java/org/apache/accumulo/core/conf/ConfigurationCo=
py.java (8326725e53ce18847f9dd920a2bf8076c6469ca3)
>>>>   *   core/src/main/java/org/apache/accumulo/core/conf/DefaultConfigur=
ation.java (17364a7662391842f33b0a29abe84e22a30ef4a9)
>>>>   *   core/src/main/java/org/apache/accumulo/core/conf/SiteConfigurati=
on.java (b410cf72e7c4f062b3607170d25ce89ce07dd35e)
>>>>   *   core/src/main/java/org/apache/accumulo/core/data/Mutation.java (=
ed51204279db2d194691b74b2885ada0cf3096e9)
>>>>   *   core/src/main/java/org/apache/accumulo/core/iterators/system/Sou=
rceSwitchingIterator.java (6c401762e4ce441753b3a04ba00481ba2a333011)
>>>>   *   core/src/test/java/org/apache/accumulo/core/client/impl/ClientCo=
ntextTest.java (494eb50d4feee985269fa286bdfc869f5e278e0e)
>>>>   *   core/src/test/java/org/apache/accumulo/core/conf/DefaultConfigur=
ationTest.java (e21db3d19d7a1bfad59a53d7a753a52ae27c0025)
>>>>   *   core/src/test/java/org/apache/accumulo/core/conf/ObservableConfi=
gurationTest.java (b92fac6fb7692dc70e42eca7fca46ffd37f5a48b)
>>>>   *   core/src/test/java/org/apache/accumulo/core/conf/SiteConfigurati=
onTest.java (f54adb15054cd0d53938ad383fbc20f4790279ac)
>>>>   *   core/src/test/java/org/apache/accumulo/core/data/MutationTest.ja=
va (6607c6e841b51b21ad5c326856e594b192a88aab)
>>>>   *   minicluster/src/main/java/org/apache/accumulo/cluster/RemoteShel=
lOptions.java (714096e16ade1ef44d1888c603c80ec11fc26a71)
>>>>   *   server/base/src/main/java/org/apache/accumulo/server/conf/Namesp=
aceConfiguration.java (bae694bdcb41874be37f0cb1d57f7e96118cd100)
>>>>   *   server/base/src/main/java/org/apache/accumulo/server/conf/TableC=
onfiguration.java (259f2a2d7f197aa2766a1a0ac69bfa00cc469d09)
>>>>   *   server/base/src/main/java/org/apache/accumulo/server/conf/ZooCac=
hePropertyAccessor.java (bec30d299f0675d67dbb156ea05ed4d9f6817f39)
>>>>   *   server/base/src/main/java/org/apache/accumulo/server/conf/ZooCon=
figuration.java (a53350ba285b3b2029c99c6faa38d50f37877a30)
>>>>   *   server/base/src/main/java/org/apache/accumulo/server/fs/Preferre=
dVolumeChooser.java (77026e6af9da9958faf33daec56deced8658fd59)
>>>>   *   server/base/src/test/java/org/apache/accumulo/server/conf/Namesp=
aceConfigurationTest.java (6bd6424242d012a163ed22b0c6f652e879c0336d)
>>>>   *   server/base/src/test/java/org/apache/accumulo/server/conf/TableC=
onfigurationTest.java (68ee2b98bdda332a2c8aa5a432ac1aee03f62d40)
>>>>   *   server/base/src/test/java/org/apache/accumulo/server/conf/ZooCac=
hePropertyAccessorTest.java (210d24047b04d9a1692204bb9b4e4b7b984d1019)
>>>>   *   server/base/src/test/java/org/apache/accumulo/server/util/FileUt=
ilTest.java (5fe35f9f43331f49b59bf66004b09d2148ee0888)
>>>>   *   test/src/test/java/org/apache/accumulo/test/util/CertUtils.java =
(3bbd7377a787585e0bf1102c43075a86243f3a71)
>>>>=20
>>>> View Diff<https://reviews.apache.org/r/33085/diff/>
>>>>=20
>>>>=20