Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-29-accumulo@git.apache.org>
In-Reply-To: <git-pr-29-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3000: Added config option
 and impl...
Content-Type: text/plain
Message-Id: <20150421211243.DC6FFE0280@git1-us-west.apache.org>
Date: Tue, 21 Apr 2015 21:12:43 +0000 (UTC)

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r28822844
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java ---
    @@ -108,6 +108,19 @@ public MiniAccumuloConfig setZooKeeperStartupTime(long zooKeeperStartupTime) {
       }
     
       /**
    +   * Configure an existing ZooKeeper instance to use. Calling this method is optional. If not set, a new ZooKeeper instance is created.
    +   *
    +   * @param existingZooKeepers
    +   *          Connection string for a already-running ZooKeeper instance
    +   *
    +   * @since 1.7.0
    +   */
    +  public MiniAccumuloConfig setExistingZooKeepers(String existingZooKeepers) {
    --- End diff --
    
    > I'm used to seeing a note on Javadoc which states when a setter is overloaded. Personally, that's sufficient.
    
    Since its really easy to do, I think structuring the API to fail fast would be better.  It avoids one case of strange failures deep in MAC that are possibly hard to debug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---