Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-29-accumulo@git.apache.org>
In-Reply-To: <git-pr-29-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3000: Added config option
 and impl...
Content-Type: text/plain
Message-Id: <20150421173022.121C5E04BB@git1-us-west.apache.org>
Date: Tue, 21 Apr 2015 17:30:22 +0000 (UTC)

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r28801819
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java ---
    @@ -108,6 +108,19 @@ public MiniAccumuloConfig setZooKeeperStartupTime(long zooKeeperStartupTime) {
       }
     
       /**
    +   * Configure an existing ZooKeeper instance to use. Calling this method is optional. If not set, a new ZooKeeper instance is created.
    +   *
    +   * @param existingZooKeepers
    +   *          Connection string for a already-running ZooKeeper instance
    +   *
    +   * @since 1.7.0
    +   */
    +  public MiniAccumuloConfig setExistingZooKeepers(String existingZooKeepers) {
    --- End diff --
    
    If its going to go into the API, I think the following needs to be considered.
    
      * Need a getter in the API.  What should the getter do/return if not set?
      * Do we want to allow the user to clear this setting, if so how does the user clear this setting?
      * Need to document in javadoc its relationship to `setZooKeeperPort()`.  Should these be made mutually exclusive?  Trying to set both would cause the 2nd set to throw an exception?
      

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---