Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-29-accumulo@git.apache.org>
In-Reply-To: <git-pr-29-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3000: Added config option
 and impl...
Content-Type: text/plain
Message-Id: <20150421153039.D3DB6DFF85@git1-us-west.apache.org>
Date: Tue, 21 Apr 2015 15:30:39 +0000 (UTC)

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/29#discussion_r28789572
  
    --- Diff: minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterExistingZooKeepersTest.java ---
    @@ -0,0 +1,100 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.minicluster;
    +
    +import static org.junit.Assert.assertTrue;
    +
    +import java.io.File;
    +import java.io.IOException;
    +
    +import org.apache.accumulo.core.client.Connector;
    +import org.apache.commons.io.FileUtils;
    +import org.apache.curator.test.TestingServer;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.rules.TestName;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +public class MiniAccumuloClusterExistingZooKeepersTest {
    +
    +  private static final Logger log = LoggerFactory.getLogger(MiniAccumuloClusterExistingZooKeepersTest.class);
    +  private File baseDir = new File(System.getProperty("user.dir") + "/target/mini-tests/" + this.getClass().getName());
    +  private TestingServer zooKeeper;
    +  private MiniAccumuloCluster accumulo;
    +
    +  @Rule
    +  public TestName testName = new TestName();
    +
    +  @Before
    +  public void setupTestCluster() throws Exception {
    +    assertTrue(baseDir.mkdirs() || baseDir.isDirectory());
    +    File testDir = new File(baseDir, testName.getMethodName());
    +    FileUtils.deleteQuietly(testDir);
    +    assertTrue(testDir.mkdir());
    +
    +    zooKeeper = new TestingServer();
    +
    +    MiniAccumuloConfig config = new MiniAccumuloConfig(testDir, "superSecret");
    +    config.setExistingZooKeepers(zooKeeper.getConnectString());
    +    accumulo = new MiniAccumuloCluster(config);
    +  }
    +
    +  @After
    +  public void teardownTestCluster() {
    +    if (accumulo != null) {
    +      try {
    +        accumulo.stop();
    +      } catch (IOException | InterruptedException e) {
    +        log.warn("Failure during tear down", e);
    +      }
    +    }
    +
    +    if (zooKeeper != null) {
    +      try {
    +        zooKeeper.close();
    +      } catch (IOException e) {
    +        log.warn("Failure stopping test ZooKeeper server");
    +      }
    +    }
    +  }
    +
    +  @Test
    +  public void multipleStartsDoesntThrowAnException() throws Exception {
    --- End diff --
    
    I don't think this test really needs to be here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---