Return-Path: 
 <dev-return-12573-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6FD88172DE
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Tue,  7 Apr 2015 20:02:08 +0000 (UTC)
Received: (qmail 60994 invoked by uid 500); 7 Apr 2015 20:02:08 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 60955 invoked by uid 500); 7 Apr 2015 20:02:08 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 60943 invoked by uid 99); 7 Apr 2015 20:02:08 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2015 20:02:08 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id D2743E17A2; Tue,  7 Apr 2015 20:02:07 +0000 (UTC)
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-25-accumulo@git.apache.org>
In-Reply-To: <git-pr-25-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner
 optimization for...
Content-Type: text/plain
Message-Id: <20150407200207.D2743E17A2@git1-us-west.apache.org>
Date: Tue,  7 Apr 2015 20:02:07 +0000 (UTC)

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r27914201
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java ---
    @@ -629,32 +676,37 @@ public float getProgress() throws IOException {
             }
             for (Map.Entry<KeyExtent,List<Range>> extentRanges : tserverBin.getValue().entrySet()) {
               Range ke = extentRanges.getKey().toDataRange();
    -          for (Range r : extentRanges.getValue()) {
    -            if (autoAdjust) {
    -              // divide ranges into smaller ranges, based on the tablets
    -              RangeInputSplit split = new RangeInputSplit(tableName, tableId, ke.clip(r), new String[] {location});
    -
    -              split.setOffline(tableConfig.isOfflineScan());
    -              split.setIsolatedScan(tableConfig.shouldUseIsolatedScanners());
    -              split.setUsesLocalIterators(tableConfig.shouldUseLocalIterators());
    -              split.setMockInstance(mockInstance);
    -              split.setFetchedColumns(tableConfig.getFetchedColumns());
    -              split.setPrincipal(principal);
    -              split.setToken(token);
    -              split.setInstanceName(instance.getInstanceName());
    -              split.setZooKeepers(instance.getZooKeepers());
    -              split.setAuths(auths);
    -              split.setIterators(tableConfig.getIterators());
    -              split.setLogLevel(logLevel);
    -
    -              splits.add(split);
    -            } else {
    -              // don't divide ranges
    -              ArrayList<String> locations = splitsToAdd.get(r);
    -              if (locations == null)
    -                locations = new ArrayList<String>(1);
    -              locations.add(location);
    -              splitsToAdd.put(r, locations);
    +          if (batchScan && supportBatchScan) {
    --- End diff --
    
    Why check `supportBatchScan` here?.   There is a check earlier that throws an exception `if (batchScan && !supportBatchScan)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---