Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: echeipesh <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-25-accumulo@git.apache.org>
In-Reply-To: <git-pr-25-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner
 optimization for...
Content-Type: text/plain
Message-Id: <20150406201547.442DCE00BB@git1-us-west.apache.org>
Date: Mon,  6 Apr 2015 20:15:47 +0000 (UTC)

Github user echeipesh commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r27826065
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java ---
    @@ -426,6 +442,7 @@ protected static ClientConfiguration getClientConfiguration(JobContext context)
          *          the table name for which the scanner is configured
          * @since 1.6.0
          */
    +    @Deprecated
         protected abstract void setupIterators(TaskAttemptContext context, Scanner scanner, String tableName, RangeInputSplit split);
    --- End diff --
    
    Could this be implemented in terms of new setupIterators without breaking semver? Would save some ugliness. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---