accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: Accumulo 3652 Refactor for slf4j string sub...
Date Thu, 23 Apr 2015 17:06:24 GMT
Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/32#issuecomment-95655661
  
    Thanks for continuing to work on this, @thormanrd. There still seem to be a bunch of unwanted
changes in here. core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnDefaultTable.java
and core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnRequiredTable.java changed
the name of the class a static method was called on. I also see a bunch of changes to the
machine-generated thrift classes (e.g. core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TDiskUsage.java).
It seems like an IDE might have been a little overzealous?
    
    Can you try to trim out the changes which were made that aren't related to slf4j, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message