accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: Clarify Accumulo API
Date Tue, 21 Apr 2015 22:43:06 GMT
Github user keith-turner commented on the pull request:

    https://github.com/apache/accumulo/pull/28#issuecomment-94964526
  
    > Also, do we want all the members on AccumuloInputSplit to be private and not package-private?
    
    Well I think some of the public members of AccumuloInputSplit used to be public methods
if RangeInputSplit.  I think some public members of AccumuloInputSplit were not intened to
be in public API, but end up there because RangeInputSplit extends AccumuloInputSplit.  I
think public API types extending impl types is nothing but trouble.   
    
    I think another issue needs to be opened.  I think the map reduce public API is a mess.
 Too much of the implementation is in the API, makes it very hard to add features.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message