accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Fri, 17 Apr 2015 15:03:40 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r28601704
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java
---
    @@ -325,27 +362,12 @@ protected void setupIterators(TaskAttemptContext context, Scanner
scanner, Strin
          *          the Hadoop context for the configured job
          * @param scanner
          *          the scanner to configure
    +     * @deprecated since 1.7.0; Use {@link #contextIterators} instead.
          */
         @Deprecated
         protected void setupIterators(TaskAttemptContext context, Scanner scanner) {
    -      setupIterators(context, scanner, null);
    -    }
    -
    -    /**
    -     * Initialize a scanner over the given input split using this task attempt configuration.
    -     */
    -    protected void setupIterators(TaskAttemptContext context, Scanner scanner, org.apache.accumulo.core.client.mapreduce.RangeInputSplit
split) {
    --- End diff --
    
    Those are different methods. Note that the one you linked includes a `String tableName`
argument where the removed one does not. I think we need both methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message