accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: Clarify Accumulo API
Date Fri, 17 Apr 2015 14:42:21 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/28#discussion_r28599651
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/data/impl/KeyExtent.java ---
    @@ -0,0 +1,769 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.data.impl;
    +
    +/**
    + * keeps track of information needed to identify a tablet
    + * apparently, we only need the endKey and not the start as well
    + *
    + */
    +
    +import java.io.ByteArrayOutputStream;
    +import java.io.DataInput;
    +import java.io.DataOutput;
    +import java.io.DataOutputStream;
    +import java.io.IOException;
    +import java.lang.ref.WeakReference;
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.Map.Entry;
    +import java.util.Set;
    +import java.util.SortedMap;
    +import java.util.SortedSet;
    +import java.util.TreeSet;
    +import java.util.UUID;
    +import java.util.WeakHashMap;
    +
    +import org.apache.accumulo.core.data.ByteSequence;
    +import org.apache.accumulo.core.data.Mutation;
    +import org.apache.accumulo.core.data.Range;
    +import org.apache.accumulo.core.data.Value;
    +import org.apache.accumulo.core.data.thrift.TKeyExtent;
    +import org.apache.accumulo.core.metadata.MetadataTable;
    +import org.apache.accumulo.core.metadata.RootTable;
    +import org.apache.accumulo.core.metadata.schema.MetadataSchema;
    +import org.apache.accumulo.core.metadata.schema.MetadataSchema.TabletsSection;
    +import org.apache.accumulo.core.util.ByteBufferUtil;
    +import org.apache.accumulo.core.util.TextUtil;
    +import org.apache.hadoop.io.BinaryComparable;
    +import org.apache.hadoop.io.Text;
    +import org.apache.hadoop.io.WritableComparable;
    +
    +public class KeyExtent implements WritableComparable<KeyExtent> {
    --- End diff --
    
    Thats a good idea.   Thinking about that, it almost seems like that could be a follow
on change unrealted to API change.  Not just make KeyExtent extend TabletID, but also look
into making implementation code use it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message