accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: Clarify Accumulo API
Date Fri, 17 Apr 2015 14:37:18 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/28#discussion_r28599203
  
    --- Diff: README.md ---
    @@ -76,15 +76,25 @@ API
     
     The public Accumulo API is composed of :
     
    - * All public classes and interfaces in the org.apache.accumulo.core.client
    -   package, as as well as all of its subpackages excluding those named *impl*.
    - * Key, Mutation, Value, Range, Condition, and ConditionalMutation in
    -   org.apache.accumulo.core.data.
    - * All public classes and interfaces in the org.apache.accumulo.minicluster
    -   package, as well as all of its subpackages excluding those named *impl*.
    - * Anything with public or protected acccess within any Class or Interface that
    -   is in the public API. This includes, but is not limited to: methods, members
    -   classes, interfaces, and enums.
    +All public types in the following packages and their subpackages excluding
    +those named *impl*, *thrift*, or *crypto*. 
    +
    +   * org.apache.accumulo.core.client
    +   * org.apache.accumulo.core.data
    +   * org.apache.accumulo.core.security
    +   * org.apache.accumulo.minicluster
    +
    +A type is a class, interface, or enum.  Anything with public or protected
    --- End diff --
    
    > Sounds like package-protected should be mentioned with private as being inaccessible.
    
    It certainly wouldn't hurt to call this out.  The only potential drawback I can think
of is making the stmt so long that no one reads its, but I don't think thats the case here.
  Also it seem like I have heard @ctubbsii mention that we build sealed jars that would prevent
users from doing this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message