accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: Clarify Accumulo API
Date Fri, 17 Apr 2015 03:39:07 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/28#discussion_r28568138
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/DelegationToken.java
---
    @@ -14,7 +14,7 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -package org.apache.accumulo.core.client.security.tokens;
    +package org.apache.accumulo.core.client.impl;
    --- End diff --
    
    This invalidates a bit of documentation within the user manual on the subject. I thought
you were going to still have a public API delegation token but move the sensitive stuff to
an impl. It seems very confusing to me to have the notion of this special token implementation
which users should/'may want to' be aware of,  but we say to the user "you don't get to know
about it or reference it".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message