accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: Clarify Accumulo API
Date Fri, 17 Apr 2015 03:21:04 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/28#discussion_r28567686
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java
---
    @@ -62,9 +62,24 @@
       private long readaheadThreshold = Constants.SCANNER_DEFAULT_READAHEAD_THRESHOLD;
     
       /**
    +   * @deprecated since 1.7.0 was never intended for public use.  However this could have
been used by anything extending this class.
    +   */
    +  @Deprecated
    +  public class ScannerTranslator extends ScannerTranslatorImpl {
    +    public ScannerTranslator(Scanner scanner) {
    +      super(scanner);
    +    }
    +
    +    @Override
    +    public SortedKeyValueIterator<Key,Value> deepCopy(final IteratorEnvironment
env) {
    +      return new ScannerTranslator(scanner);
    +    }
    +  }
    +
    +  /**
        * A class that wraps a Scanner in a SortedKeyValueIterator so that other accumulo
iterators can use it as a source.
        */
    -  public class ScannerTranslator implements SortedKeyValueIterator<Key,Value> {
    +  private class ScannerTranslatorImpl implements SortedKeyValueIterator<Key,Value>
{
    --- End diff --
    
    Doesn't this break public API?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message