accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Thu, 16 Apr 2015 22:47:00 GMT
Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/25#issuecomment-93856225
  
    Ok, two things I think need to be fixed. Everything else you fixed looks good!
    
    1. Restore the `setupIterators(TaskAttemptContext, Scanner, RangeInputSplit)` method (this
is another one of those crappy edge cases, sorry).
    2. Fail if `batchScan==true` while `autoAdjust==true`
    
    I pulled down the PR and ran it through japi which is how I noticed the first point. Otherwise
it looks good from a compatibility sense for 1.6->1.7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message