accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <>
Subject [GitHub] accumulo pull request: ACCUMULO-3709: Update both output formats. ...
Date Mon, 13 Apr 2015 14:59:07 GMT
Github user joshelser commented on a diff in the pull request:
    --- Diff: test/src/test/java/org/apache/accumulo/test/ ---
    @@ -0,0 +1,160 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.test;
    +import static;
    +import java.util.Map;
    +import java.util.concurrent.TimeUnit;
    +import org.apache.accumulo.core.client.BatchWriterConfig;
    +import org.apache.accumulo.core.client.Connector;
    +import org.apache.accumulo.core.client.ZooKeeperInstance;
    +import org.apache.accumulo.core.client.mapred.AccumuloOutputFormat;
    +import org.apache.accumulo.core.client.mapreduce.lib.util.OutputConfigurator;
    +import org.apache.accumulo.core.conf.Property;
    +import org.apache.accumulo.minicluster.MiniAccumuloCluster;
    +import org.apache.accumulo.minicluster.MiniAccumuloConfig;
    +import org.apache.hadoop.mapred.JobConf;
    +import org.apache.hadoop.mapred.RecordWriter;
    +import org.apache.hadoop.mapreduce.Job;
    +import org.apache.hadoop.mapreduce.TaskAttemptContext;
    +import org.apache.hadoop.mapreduce.TaskAttemptID;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.junit.rules.TemporaryFolder;
    + * Exists because mock instance doesn't produce this error when dynamically changing
the table permissions.
    + */
    +public class AccumuloOutputFormatTest {
    +  private static final String TABLE = "abc";
    +  public static TemporaryFolder folder = new TemporaryFolder();
    --- End diff --
    Would be nice to put this in `target/` instead of a random temporary folder. Makes future
debugging easier. Something like `System.getProperty("user.dir") + "/target/" + getClass().getName()`
usually is sufficient.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message