accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From echeipesh <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Fri, 10 Apr 2015 18:20:20 GMT
Github user echeipesh commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r28168170
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java
---
    @@ -86,15 +87,8 @@ public boolean nextKeyValue() throws IOException, InterruptedException
{
           }
     
           @Override
    -      protected void setupIterators(TaskAttemptContext context, Scanner scanner, String
tableName, RangeInputSplit split) {
    -        List<IteratorSetting> iterators = split.getIterators();
    -        if (null == iterators) {
    -          iterators = getInputTableConfig(context, tableName).getIterators();
    -        }
    -
    -        for (IteratorSetting setting : iterators) {
    -          scanner.addScanIterator(setting);
    -        }
    +      protected List<IteratorSetting> contextIterators(TaskAttemptContext context,
String tableName) {
    +        return getInputTableConfig(context, tableName).getIterators();
    --- End diff --
    
    I notice that `mapred.MultiTableInputFormat` does not have similar logic but just uses
Reader from `InputFormatBase` which appears to assume there is only one table target:
    https://github.com/apache/accumulo/blob/master/core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloMultiTableInputFormat.java#L68
    
    I am not sure if this is a bug, as it looks like, or there is some reason for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message