accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Billie Rinaldi" <bil...@apache.org>
Subject Re: Review Request 32986: ACCUMULO-3715 Decrease sampling percentage for tracing
Date Thu, 09 Apr 2015 15:58:10 GMT


> On April 9, 2015, 3 a.m., Mike Drob wrote:
> > core/src/main/java/org/apache/accumulo/core/conf/Property.java, line 385
> > <https://reviews.apache.org/r/32986/diff/1/?file=921041#file921041line385>
> >
> >     If this property name changes, should we provide some level of support for the
old name?

I introduced this property in 1.7.  When I came back to it, I found it confusing because trace.span.receiver.
properties are passed down automatically to the span receiver, but this path property is read
in DistributedTrace and translated to trace.span.receiver.tracer.zookeeper.path when passed
to the span receiver.  I figured I should either change its name to trace.span.receiver.tracer.zookeeper.path
so it would not need special handling, or remove it from the t.s.r. naming convention so it's
clear that it is handled specially.


- Billie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32986/#review79472
-----------------------------------------------------------


On April 9, 2015, 3:57 p.m., Billie Rinaldi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32986/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 3:57 p.m.)
> 
> 
> Review request for accumulo, Eric Newton and Josh Elser.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Make sampling of traces configurable; clean up and standardize config parameters; update
documentation
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java 9dceb1e 
>   core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java c5b6eac 
>   core/src/main/java/org/apache/accumulo/core/trace/ProbabilitySampler.java PRE-CREATION

>   docs/src/main/asciidoc/chapters/administration.txt 0382934 
>   server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 04f21a1

>   server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java
63c6b20 
>   server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java
4e05b89 
>   server/tracer/src/main/java/org/apache/accumulo/tracer/AsyncSpanReceiver.java dbcb335

>   server/tracer/src/main/java/org/apache/accumulo/tracer/TraceDump.java e4eb70e 
>   server/tracer/src/main/java/org/apache/accumulo/tracer/TraceTableStats.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
cb8ae13 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java
0f6a98d 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 43bd9d9

> 
> Diff: https://reviews.apache.org/r/32986/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Billie Rinaldi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message