accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...
Date Thu, 09 Apr 2015 01:53:45 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/22#discussion_r28030148
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
---
    @@ -1860,9 +1860,14 @@ private CompactionStats _majorCompact(MajorCompactionReason reason)
throws IOExc
     
           if (inputFiles.isEmpty()) {
             if (reason == MajorCompactionReason.USER) {
    -          // no work to do
    -          lastCompactID = compactionId.getFirst();
    -          updateCompactionID = true;
    +          if (compactionId.getSecond().getIterators().isEmpty()) {
    +            log.debug("No-op major compaction by USER on 0 input files because no iterators
present.");
    +            lastCompactID = compactionId.getFirst();
    +            updateCompactionID = true;
    +          } else {
    +            log.debug("Major compaction by USER on 0 input files with iterators.");
    +            filesToCompact = new HashMap<FileRef,DataFileValue>();
    --- End diff --
    
    nit, you can just use the diamond operator


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message