accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From echeipesh <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Wed, 08 Apr 2015 15:56:50 GMT
Github user echeipesh commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r27983742
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java
---
    @@ -384,7 +387,21 @@ public static InputTableConfig getInputTableConfig(JobConf job, String
tableName
       protected abstract static class AbstractRecordReader<K,V> implements RecordReader<K,V>
{
         protected long numKeysRead;
         protected Iterator<Map.Entry<Key,Value>> scannerIterator;
    -    protected RangeInputSplit split;
    +    protected org.apache.accumulo.core.client.mapreduce.impl.AccumuloInputSplit split;
    +    protected ScannerBase scannerBase;
    +
    +    /**
    +     * Configures the iterators on a scanner for the given table name.
    +     *
    +     * @param job
    +     *          the Hadoop job configuration
    +     * @param scanner
    +     *          the scanner for which to configure the iterators
    +     * @param tableName
    +     *          the table name for which the scanner is configured
    +     * @since 1.7.0
    +     */
    +    protected abstract void setupIterators(JobConf job, ScannerBase scanner, String tableName,
AccumuloInputSplit split);
    --- End diff --
    
    That's a good point. In an effort to avoid mistakes of the past and keep AccumulInputSplit
out of public API how about something like this:
    
    ```java
    // InputFormatBase
    List<IteratorSetting> contextIterators(TaskAttemptContext context, String tableName)
{
      return getIterators(context).getIterators();
    }
    
    // AccumululoMultiTableInputFormat
    List<IteratorSetting> contextIterators(TaskAttemptContext context, String tableName)
{
      return getInputTableConfig(context, tableName).getIterators();
    }
    
    // lift setupIterators to AbstractInputFormat (no longer abstract)
    protected abstract List<IteratorSetting> contextIterators(TaskAttemptContext context,
String tableName);
    
    private void setupIterators(TaskAttemptContext context, ScannerBase scanner, String tableName,
AccumuloInputSplit split) {
        List<IteratorSetting> iterators = null;
        if (null == split) {
          iterators = contextIterators(context);
        } else {
          iterators = split.getIterators();
          if (null == iterators) {
            iterators = contextIterators(context);
          }
        }
        for (IteratorSetting iterator : iterators)
          scanner.addScanIterator(iterator);
    }
    ```
    Looking at code right now the only part that diverges is pulling out default split if
they're somehow unavailable in the split. This narrows the interface, hopefully in an acceptable
way?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message