accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Wed, 08 Apr 2015 15:14:56 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r27979336
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java
---
    @@ -315,7 +317,11 @@ protected static TabletLocator getTabletLocator(JobConf job) throws
TableNotFoun
       protected abstract static class RecordReaderBase<K,V> extends AbstractRecordReader<K,V>
{
     
         @Override
    -    protected void setupIterators(JobConf job, Scanner scanner, String tableName, org.apache.accumulo.core.client.mapred.RangeInputSplit
split) {
    +    protected void setupIterators(JobConf job, ScannerBase scanner, String tableName,
AccumuloInputSplit split) {
    --- End diff --
    
    > There's a since tag on AbstractRecordReader. Isn't that sufficient?
    
    oic, yeah thats good. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message