accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Tue, 07 Apr 2015 22:13:40 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r27926398
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java
---
    @@ -517,6 +517,74 @@ public static Boolean isOfflineScan(Class<?> implementingClass,
Configuration co
       }
     
       /**
    +   * Controls the use of the {@link BatchScanner} in this job.
    +   * Using this feature will group ranges by their source tablet per InputSplit and use
BatchScanner to read them.
    --- End diff --
    
    Could mention what options this will not work with in javadoc.  For example setting this
will not work w/ offline scan and local iters.
    
    Could also mention the benefit of doing this.  It seems the main benefit is one RPC to
send multiple ranges to a tserver and then read the results, versus an RPC per range.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message