accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From denine99 <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...
Date Fri, 03 Apr 2015 05:25:03 GMT
Github user denine99 commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/22#discussion_r27715976
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/user/HardListIterator.java
---
    @@ -0,0 +1,111 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.iterators.user;
    +
    +import org.apache.accumulo.core.data.ByteSequence;
    +import org.apache.accumulo.core.data.Key;
    +import org.apache.accumulo.core.data.PartialKey;
    +import org.apache.accumulo.core.data.Range;
    +import org.apache.accumulo.core.data.Value;
    +import org.apache.accumulo.core.iterators.IteratorEnvironment;
    +import org.apache.accumulo.core.iterators.SortedKeyValueIterator;
    +import org.apache.accumulo.core.util.PeekingIterator;
    +import org.apache.hadoop.io.Text;
    +import org.apache.log4j.Logger;
    +
    +import java.io.IOException;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.Map;
    +import java.util.SortedMap;
    +import java.util.TreeMap;
    +
    +/**
    + * A wrapper making a list of hardcoded data into a SKVI. For testing.
    + */
    +public class HardListIterator implements SortedKeyValueIterator<Key,Value> {
    +  private static final Logger log = Logger.getLogger(HardListIterator.class);
    +  public final static SortedMap<Key,Value> allEntriesToInject;
    +  static {
    +    SortedMap<Key,Value> t = new TreeMap<>();
    +    t.put(new Key(new Text("a1"), new Text("colF3"), new Text("colQ3"), System.currentTimeMillis()),
new Value("1".getBytes()));
    +    t.put(new Key(new Text("c1"), new Text("colF3"), new Text("colQ3"), System.currentTimeMillis()),
new Value("1".getBytes()));
    +    t.put(new Key(new Text("m1"), new Text("colF3"), new Text("colQ3"), System.currentTimeMillis()),
new Value("1".getBytes()));
    +    allEntriesToInject = Collections.unmodifiableSortedMap(t); // for safety
    +  }
    +
    +  private PeekingIterator<Map.Entry<Key,Value>> inner;
    +  private Range seekRng;
    +
    +  @Override
    +  public void init(SortedKeyValueIterator<Key,Value> source, Map<String,String>
options, IteratorEnvironment env) throws IOException {
    --- End diff --
    
    Forgot to comment on this after committing-- I moved the class into the main code of the
test project.  I did this so that I could deploy the test code JAR in a standalone Accumulo
cluster after calling `mvn package -DskipITs` and then do the test.  Maybe the Accumulo build
has an automated way to deploy JARs containing test src code in standalone instances via the
configuration?  If not, this is a good compromise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message