accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Thu, 02 Apr 2015 02:56:02 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r27629761
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/RangeInputSplit.java
---
    @@ -179,81 +93,13 @@ public void readFields(DataInput in) throws IOException {
         if (in.readBoolean()) {
           localIterators = in.readBoolean();
         }
    -
    -    if (in.readBoolean()) {
    -      mockInstance = in.readBoolean();
    -    }
    -
    -    if (in.readBoolean()) {
    -      int numColumns = in.readInt();
    -      List<String> columns = new ArrayList<String>(numColumns);
    -      for (int i = 0; i < numColumns; i++) {
    -        columns.add(in.readUTF());
    -      }
    -
    -      fetchedColumns = InputConfigurator.deserializeFetchedColumns(columns);
    -    }
    -
    -    if (in.readBoolean()) {
    -      String strAuths = in.readUTF();
    -      auths = new Authorizations(strAuths.getBytes(UTF_8));
    -    }
    -
    -    if (in.readBoolean()) {
    -      principal = in.readUTF();
    -    }
    -
    -    if (in.readBoolean()) {
    -      int ordinal = in.readInt();
    -      this.tokenSource = TokenSource.values()[ordinal];
    -
    -      switch (this.tokenSource) {
    -        case INLINE:
    -          String tokenClass = in.readUTF();
    -          byte[] base64TokenBytes = in.readUTF().getBytes(UTF_8);
    -          byte[] tokenBytes = Base64.decodeBase64(base64TokenBytes);
    -
    -          this.token = AuthenticationTokenSerializer.deserialize(tokenClass, tokenBytes);
    -          break;
    -
    -        case FILE:
    -          this.tokenFile = in.readUTF();
    -
    -          break;
    -        default:
    -          throw new IOException("Cannot parse unknown TokenSource ordinal");
    -      }
    -    }
    -
    -    if (in.readBoolean()) {
    -      instanceName = in.readUTF();
    -    }
    -
    -    if (in.readBoolean()) {
    -      zooKeepers = in.readUTF();
    -    }
    -
    -    if (in.readBoolean()) {
    -      int numIterators = in.readInt();
    -      iterators = new ArrayList<IteratorSetting>(numIterators);
    -      for (int i = 0; i < numIterators; i++) {
    -        iterators.add(new IteratorSetting(in));
    -      }
    -    }
    -
    -    if (in.readBoolean()) {
    -      level = Level.toLevel(in.readInt());
    -    }
       }
     
       @Override
       public void write(DataOutput out) throws IOException {
    --- End diff --
    
    Need to serialize offline here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message