accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Thu, 02 Apr 2015 02:55:48 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r27629755
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/RangeInputSplit.java
---
    @@ -135,38 +72,15 @@ public float getProgress(Key currentKey) {
        */
       @Override
       public long getLength() throws IOException {
    -    Text startRow = range.isInfiniteStartKey() ? new Text(new byte[] {Byte.MIN_VALUE})
: range.getStartKey().getRow();
    -    Text stopRow = range.isInfiniteStopKey() ? new Text(new byte[] {Byte.MAX_VALUE})
: range.getEndKey().getRow();
    -    int maxCommon = Math.min(7, Math.min(startRow.getLength(), stopRow.getLength()));
    -    long diff = 0;
    -
    -    byte[] start = startRow.getBytes();
    -    byte[] stop = stopRow.getBytes();
    -    for (int i = 0; i < maxCommon; ++i) {
    -      diff |= 0xff & (start[i] ^ stop[i]);
    -      diff <<= Byte.SIZE;
    -    }
    -
    -    if (startRow.getLength() != stopRow.getLength())
    -      diff |= 0xff;
    -
    -    return diff + 1;
    +    return getRangeLength(range);
       }
     
    -  @Override
    -  public String[] getLocations() throws IOException {
    -    return Arrays.copyOf(locations, locations.length);
    -  }
     
       @Override
       public void readFields(DataInput in) throws IOException {
    --- End diff --
    
    Need to get offline from the serialization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message