accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Thu, 02 Apr 2015 02:52:46 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r27629663
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java
---
    @@ -323,7 +382,7 @@ protected static TabletLocator getTabletLocator(JobContext context)
throws Table
          * @since 1.6.0
          */
         @Override
    -    protected void setupIterators(TaskAttemptContext context, Scanner scanner, String
tableName, org.apache.accumulo.core.client.mapreduce.RangeInputSplit split) {
    +    protected void setupIterators(TaskAttemptContext context, ScannerBase scanner, String
tableName, org.apache.accumulo.core.client.mapreduce.AccumuloInputSplit split) {
    --- End diff --
    
    Sorry, we can't change these as they'd break API from 1.6.0. We can add to the API for
1.7.0, but we can't remove. Need to deprecate the ones that take Scanner and add in a new
one for ScannerBase. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message