accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...
Date Thu, 02 Apr 2015 02:51:01 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/25#discussion_r27629593
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java
---
    @@ -296,6 +296,65 @@ protected static boolean isOfflineScan(JobContext context) {
       }
     
       /**
    +   * Controls the use of the {@link org.apache.accumulo.core.client.BatchScanner} in
this job.
    +   * Using this feature will group ranges by their source tablet per InputSplit and use
BatchScanner to read them.
    +   *
    +   * <p>
    +   * By default, this feature is <b>disabled</b>.
    +   *
    +   * @param job
    +   *          the Hadoop job instance to be configured
    +   * @param enableFeature
    +   *          the feature is enabled if true, disabled otherwise
    +   * @since 1.7.0
    +   */
    +  public static void setBatchScan(Job job, boolean enableFeature) {
    +    InputConfigurator.setBatchScan(CLASS, job.getConfiguration(), enableFeature);
    +  }
    +
    +  /**
    +   * Determines whether a configuration has the {@link org.apache.accumulo.core.client.BatchScanner}
feature enabled.
    +   *
    +   * @param context
    +   *          the Hadoop context for the configured job
    +   * @since 1.7.0
    +   * @see #setBatchScan(Job, boolean)
    +   */
    +  protected static boolean isBatchScan(JobContext context) {
    --- End diff --
    
    Why JobContext here? And why not public?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message