Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BE5E17FBB for ; Thu, 19 Mar 2015 02:10:35 +0000 (UTC) Received: (qmail 7142 invoked by uid 500); 19 Mar 2015 02:10:35 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 7099 invoked by uid 500); 19 Mar 2015 02:10:35 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 7087 invoked by uid 99); 19 Mar 2015 02:10:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 02:10:34 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of josh.elser@gmail.com designates 209.85.216.173 as permitted sender) Received: from [209.85.216.173] (HELO mail-qc0-f173.google.com) (209.85.216.173) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 02:10:21 +0000 Received: by qcaz10 with SMTP id z10so55583287qca.1 for ; Wed, 18 Mar 2015 19:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=RvPOifDGz9M3M6V5Hus9u2ynLbCeTIwg+5VEPTBsF58=; b=zw11YSrHv0UlMUXlv5rPCQ8Yr7a3/W3V+KeJw76QirilPz3ugyCTBK9eJFJrJ7rtBq YNJMgBaItcT8T2YCOA7Bv0JpVVRnIVEykOKPNzAs/XOqzfeS0JM3DmS6S+kTuFTSxhyc p8ehqRO/idlzHcMlK6NljEHet0T9wbTp6EBoGdKQ7CYV2PobIkHjmt8TOZA3MyaO1b+u M5PFT/4JBbvhnFoeeAvs1xdw/xX/TrJQll3oyV/PawOqO/GuRzr2QY/h3D3I4y8DmRJd jiottzPgEqgYJgSOvA3yqFNpiUr30yM/6DAQetPB2Ea0ZJgLDQFF/wRAcbWsEGclGY9g NoAw== X-Received: by 10.140.107.166 with SMTP id h35mr92463822qgf.71.1426731001377; Wed, 18 Mar 2015 19:10:01 -0700 (PDT) Received: from hw10447.local (pool-72-81-135-153.bltmmd.fios.verizon.net. [72.81.135.153]) by mx.google.com with ESMTPSA id n41sm13109399qkh.3.2015.03.18.19.10.00 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 18 Mar 2015 19:10:00 -0700 (PDT) Message-ID: <550A2FF7.5020907@gmail.com> Date: Wed, 18 Mar 2015 22:09:59 -0400 From: Josh Elser User-Agent: Postbox 3.0.11 (Macintosh/20140602) MIME-Version: 1.0 To: dev@accumulo.apache.org Subject: Re: Review Request 32224: ACCUMULO-3423 References: <20150318235806.19861.53178@reviews.apache.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Thanks for the heads up. FYI, I plan to give it another pass tonight or tmrw. Eric Newton wrote: > I know this thing is huge. Josh has already been over it a couple of times. > > I plan to push it to master very soon. If you would like to hold off for a > more intensive review, please let me know. > > At this point, I've run the tests so many times, the ITs are more stable in > my branch than in master. > > You can also find this at github: > > https://github.com/ericnewton/accumulo-3423 > > -Eric > > > On Wed, Mar 18, 2015 at 7:58 PM, Eric Newton wrote: > >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/32224/ >> ----------------------------------------------------------- >> >> Review request for accumulo. >> >> >> Repository: accumulo >> >> >> Description >> ------- >> >> Faster WAL rollovers >> >> >> Diffs >> ----- >> >> >> core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java >> 6a5c74a >> core/src/main/java/org/apache/accumulo/core/conf/Property.java 2403915 >> core/src/main/java/org/apache/accumulo/core/metadata/RootTable.java >> 24148b1 >> >> core/src/main/java/org/apache/accumulo/core/metadata/schema/MetadataSchema.java >> 534dd7f >> >> core/src/main/java/org/apache/accumulo/core/tabletserver/log/LogEntry.java >> 25d0f32 >> >> core/src/test/java/org/apache/accumulo/core/metadata/MetadataTableSchemaTest.java >> PRE-CREATION >> server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java >> fc26ca4 >> >> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java >> e5bdded >> >> server/base/src/main/java/org/apache/accumulo/server/master/state/MetaDataStateStore.java >> 7ee6f0c >> >> server/base/src/main/java/org/apache/accumulo/server/master/state/MetaDataTableScanner.java >> 9be5a67 >> >> server/base/src/main/java/org/apache/accumulo/server/master/state/TabletLocationState.java >> b24b562 >> >> server/base/src/main/java/org/apache/accumulo/server/master/state/TabletStateStore.java >> 5413e31 >> >> server/base/src/main/java/org/apache/accumulo/server/master/state/ZooTabletStateStore.java >> ab99396 >> >> server/base/src/main/java/org/apache/accumulo/server/replication/StatusUtil.java >> 898e3d4 >> >> server/base/src/main/java/org/apache/accumulo/server/util/ListVolumesUsed.java >> e90d1dd >> >> server/base/src/main/java/org/apache/accumulo/server/util/MasterMetadataUtil.java >> 4ca2d64 >> >> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java >> 10cd749 >> >> server/base/src/main/java/org/apache/accumulo/server/util/ReplicationTableUtil.java >> af02a8d >> >> server/base/src/test/java/org/apache/accumulo/server/util/ReplicationTableUtilTest.java >> b1010c2 >> >> server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java >> 1735c0d >> >> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java >> c8d5cd6 >> >> server/gc/src/main/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferences.java >> 3a32727 >> >> server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogsTest.java >> 5801faa >> >> server/gc/src/test/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferencesTest.java >> 23db83a >> server/master/src/main/java/org/apache/accumulo/master/Master.java >> 3762f32 >> >> server/master/src/main/java/org/apache/accumulo/master/MasterClientServiceHandler.java >> f73c236 >> >> server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java >> d097d75 >> >> server/master/src/main/java/org/apache/accumulo/master/replication/WorkMaker.java >> 8532e1b >> >> server/master/src/main/java/org/apache/accumulo/master/state/MergeStats.java >> 44f229e >> >> server/master/src/test/java/org/apache/accumulo/master/ReplicationOperationsImplTest.java >> a127dcd >> >> server/master/src/test/java/org/apache/accumulo/master/TestMergeState.java >> b0240f1 >> >> server/master/src/test/java/org/apache/accumulo/master/state/RootTabletStateStoreTest.java >> abceae4 >> server/tserver/src/main/findbugs/exclude-filter.xml 47dd1f5 >> >> server/tserver/src/main/java/org/apache/accumulo/server/GarbageCollectionLogger.java >> 8f3785e >> >> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletLevel.java >> PRE-CREATION >> >> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java >> 662ee31 >> >> server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java >> 5acf5eb >> >> server/tserver/src/main/java/org/apache/accumulo/tserver/log/SortedLogRecovery.java >> c4d9fab >> >> server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java >> 711c497 >> >> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java >> b4814e4 >> >> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java >> 594d9c5 >> >> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java >> 6152500 >> >> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java >> 4bc05a6 >> >> test/src/main/java/org/apache/accumulo/test/performance/thrift/NullTserver.java >> b429607 >> test/src/test/java/org/apache/accumulo/proxy/ProxyDurabilityIT.java >> 404a8fd >> >> test/src/test/java/org/apache/accumulo/test/BadDeleteMarkersCreatedIT.java >> 25337b2 >> test/src/test/java/org/apache/accumulo/test/BalanceIT.java f793925 >> test/src/test/java/org/apache/accumulo/test/CleanWalIT.java f553be8 >> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java >> bd00f02 >> >> test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java >> b78a311 >> test/src/test/java/org/apache/accumulo/test/NoMutationRecoveryIT.java >> 6a9975c >> test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 56a6a70 >> >> test/src/test/java/org/apache/accumulo/test/functional/WALSunnyDayIT.java >> PRE-CREATION >> >> test/src/test/java/org/apache/accumulo/test/functional/WatchTheWatchCountIT.java >> bd0555b >> >> test/src/test/java/org/apache/accumulo/test/performance/RollWALPerformanceIT.java >> PRE-CREATION >> >> test/src/test/java/org/apache/accumulo/test/replication/GarbageCollectorCommunicatesWithTServersIT.java >> 5b89d9c >> >> test/src/test/java/org/apache/accumulo/test/replication/MultiInstanceReplicationIT.java >> 9dec16e >> >> test/src/test/java/org/apache/accumulo/test/replication/ReplicationIT.java >> 54348db >> >> Diff: https://reviews.apache.org/r/32224/diff/ >> >> >> Testing >> ------- >> >> Ran all tests, except RandomWalk. >> >> >> Thanks, >> >> Eric Newton >> >> >