Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-22-accumulo@git.apache.org>
In-Reply-To: <git-pr-22-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major
 compac...
Content-Type: text/plain
Message-Id: <20150312171800.D97C1E18D3@git1-us-west.apache.org>
Date: Thu, 12 Mar 2015 17:18:00 +0000 (UTC)

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/22#discussion_r26323276
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/EverythingCompactionStrategy.java ---
    @@ -27,7 +27,7 @@
     
       @Override
       public boolean shouldCompact(MajorCompactionRequest request) throws IOException {
    -    return request.getFiles().size() > 0;
    +      return true; // ACCUMULO-3645 compact for empty files too
    --- End diff --
    
    Rather than change the default compaction strategy, it'd probably be better to introduce a new compaction strategy, which returns true, instead of implementing the optimized behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---