accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <>
Subject [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...
Date Sat, 28 Mar 2015 21:04:35 GMT
Github user joshelser commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/user/
    @@ -0,0 +1,111 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.iterators.user;
    +import org.apache.accumulo.core.iterators.IteratorEnvironment;
    +import org.apache.accumulo.core.iterators.SortedKeyValueIterator;
    +import org.apache.accumulo.core.util.PeekingIterator;
    +import org.apache.log4j.Logger;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.Map;
    +import java.util.SortedMap;
    +import java.util.TreeMap;
    + * A wrapper making a list of hardcoded data into a SKVI. For testing.
    + */
    +public class HardListIterator implements SortedKeyValueIterator<Key,Value> {
    +  private static final Logger log = Logger.getLogger(HardListIterator.class);
    +  public final static SortedMap<Key,Value> allEntriesToInject;
    +  static {
    +    SortedMap<Key,Value> t = new TreeMap<>();
    +    t.put(new Key(new Text("a1"), new Text("colF3"), new Text("colQ3"), System.currentTimeMillis()),
new Value("1".getBytes()));
    +    t.put(new Key(new Text("c1"), new Text("colF3"), new Text("colQ3"), System.currentTimeMillis()),
new Value("1".getBytes()));
    +    t.put(new Key(new Text("m1"), new Text("colF3"), new Text("colQ3"), System.currentTimeMillis()),
new Value("1".getBytes()));
    +    allEntriesToInject = Collections.unmodifiableSortedMap(t); // for safety
    +  }
    +  private PeekingIterator<Map.Entry<Key,Value>> inner;
    +  private Range seekRng;
    +  @Override
    +  public void init(SortedKeyValueIterator<Key,Value> source, Map<String,String>
options, IteratorEnvironment env) throws IOException {
    --- End diff --
    Yes, putting HardListIterator in src/test/java will place it in the test jar instead of
the "regular" jar. I don't think we put the core test-jar on the classpath for ITs. You can
(should, IMO) put it in test/src/test/java instead of core/src/main/java and that will work
for your integration test.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message