accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...
Date Fri, 27 Mar 2015 19:23:28 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/22#discussion_r27323786
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
---
    @@ -2566,12 +2579,7 @@ public void compactAll(long compactionId, UserCompactionConfig
compactionConfig)
           if (isClosing() || isClosed() || majorCompactionQueued.contains(MajorCompactionReason.USER)
|| isMajorCompactionRunning())
             return;
     
    -      if (getDatafileManager().getDatafileSizes().size() == 0) {
    -        // no files, so jsut update the metadata table
    -        majorCompactionState = CompactionState.IN_PROGRESS;
    -        updateMetadata = true;
    -        lastCompactID = compactionId;
    -      } else {
    +      {
    --- End diff --
    
    Why leave this undconditional code block?  Did a var name conflict?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message