accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...
Date Fri, 13 Mar 2015 00:24:04 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/22#discussion_r26357025
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/EverythingCompactionStrategy.java
---
    @@ -27,7 +27,7 @@
     
       @Override
       public boolean shouldCompact(MajorCompactionRequest request) throws IOException {
    -    return request.getFiles().size() > 0;
    +      return true; // ACCUMULO-3645 compact for empty files too
    --- End diff --
    
    A point to consider: unless it's definitely a bug fix, and we're sure we want to change
the behavior to fix that bug, our versioning rules would disallow new functionality to be
added in 1.6.3. It'd have to go in 1.7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message