accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...
Date Fri, 13 Mar 2015 00:20:41 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/22#discussion_r26356908
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/EverythingCompactionStrategy.java
---
    @@ -27,7 +27,7 @@
     
       @Override
       public boolean shouldCompact(MajorCompactionRequest request) throws IOException {
    -    return request.getFiles().size() > 0;
    +      return true; // ACCUMULO-3645 compact for empty files too
    --- End diff --
    
    I think I'd only be in favor of making the change for 1.6.3 if it's done as a new CompactionStrategy.
I'd need convincing to change the default implementation in a bug fix release without seriously
enumerating the corner cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message