accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From denine99 <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...
Date Thu, 12 Mar 2015 23:47:14 GMT
Github user denine99 commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/22#discussion_r26355215
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
---
    @@ -1861,8 +1861,10 @@ private CompactionStats _majorCompact(MajorCompactionReason reason)
throws IOExc
           if (inputFiles.isEmpty()) {
             if (reason == MajorCompactionReason.USER) {
               // no work to do
    -          lastCompactID = compactionId.getFirst();
    -          updateCompactionID = true;
    +//          lastCompactID = compactionId.getFirst();
    --- End diff --
    
    Yes, touching `lastCompactID` is sensitive because Accumulo uses that to determine when
a compaction has already occurred. I think the modifications are correct, but I retained the
commented lines because I feel unsure.  I will remove the commented lines and try to test
further.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message