accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From denine99 <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...
Date Thu, 12 Mar 2015 23:43:50 GMT
Github user denine99 commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/22#discussion_r26355050
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/EverythingCompactionStrategy.java
---
    @@ -27,7 +27,7 @@
     
       @Override
       public boolean shouldCompact(MajorCompactionRequest request) throws IOException {
    -    return request.getFiles().size() > 0;
    +      return true; // ACCUMULO-3645 compact for empty files too
    --- End diff --
    
    The only time this will make a difference is when the USER manually issues a compaction
with at least one iterator, in which case the user should expect the compaction occurs by
default.
    
    I will add a condition to the Tablet code to keep the "optimized" behavior for empty tablets
on user-issued compactions that do not have any iterators configured.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message