accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...
Date Thu, 12 Mar 2015 17:22:22 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/22#discussion_r26323700
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
---
    @@ -1861,8 +1861,10 @@ private CompactionStats _majorCompact(MajorCompactionReason reason)
throws IOExc
           if (inputFiles.isEmpty()) {
             if (reason == MajorCompactionReason.USER) {
               // no work to do
    -          lastCompactID = compactionId.getFirst();
    -          updateCompactionID = true;
    +//          lastCompactID = compactionId.getFirst();
    --- End diff --
    
    What was your intention in leaving these commented out?
    I'm not too familiar with how the compactionId is used, but it seems like getting this
right is tricky.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message