Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 57CE617E93 for ; Thu, 29 Jan 2015 20:17:34 +0000 (UTC) Received: (qmail 10316 invoked by uid 500); 29 Jan 2015 20:17:34 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 10273 invoked by uid 500); 29 Jan 2015 20:17:34 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 10232 invoked by uid 99); 29 Jan 2015 20:17:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jan 2015 20:17:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D58361D955F; Thu, 29 Jan 2015 20:17:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8247715003085862390==" MIME-Version: 1.0 Subject: Re: Review Request 30382: ACCUMULO-3514 Use auto service for start From: "Mike Drob" To: "Mike Drob" , "Christopher Tubbs" , "accumulo" Date: Thu, 29 Jan 2015 20:17:28 -0000 Message-ID: <20150129201728.25679.68024@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mike Drob" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/30382/ X-Sender: "Mike Drob" References: <20150128223917.25680.10853@reviews.apache.org> In-Reply-To: <20150128223917.25680.10853@reviews.apache.org> Reply-To: "Mike Drob" X-ReviewRequest-Repository: accumulo --===============8247715003085862390== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30382/#review70260 ----------------------------------------------------------- server/master/src/main/java/org/apache/accumulo/master/MasterExecutable.java nit: empty javadoc start/src/main/java/org/apache/accumulo/start/Main.java Create simple Executors for these too so that they are not special cased. start/src/main/java/org/apache/accumulo/start/Main.java StringUtils.join() ? start/src/main/java/org/apache/accumulo/start/Main.java Why a ConcurrentHashMap? start/src/main/java/org/apache/accumulo/start/spi/KeywordExecutable.java Is this import just for the docs? - Mike Drob On Jan. 28, 2015, 10:39 p.m., Christopher Tubbs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30382/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 10:39 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3514 > https://issues.apache.org/jira/browse/ACCUMULO-3514 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-3514 Use auto-service for start > > Use @AutoService annotations and Java's ServiceLoader mechanism to discover > classes which are executable by Accumulo's "start" jar with a keyword. > > This replaces manual intervention whenever we add a new option to the > bin/accumulo script and also auto-populates the usage for that script. > > > Diffs > ----- > > core/pom.xml 5fc7a6e > core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java f29efcc > core/src/main/java/org/apache/accumulo/core/util/CreateToken.java 79b241c > minicluster/pom.xml ee6cdc8 > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java c45abc0 > pom.xml dda1cfe > proxy/pom.xml 9312d7b > proxy/src/main/java/org/apache/accumulo/proxy/Proxy.java 0a4d12e > server/base/pom.xml c21a168 > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 0a1f411 > server/base/src/main/java/org/apache/accumulo/server/util/Admin.java 77d5ea1 > server/base/src/main/java/org/apache/accumulo/server/util/Info.java 29fa135 > server/base/src/main/java/org/apache/accumulo/server/util/LoginProperties.java be5a7c8 > server/base/src/main/java/org/apache/accumulo/server/util/ZooKeeperMain.java 0edcf71 > server/gc/pom.xml 9602b95 > server/gc/src/main/java/org/apache/accumulo/gc/GCExecutable.java PRE-CREATION > server/master/pom.xml 7e9ab1d > server/master/src/main/java/org/apache/accumulo/master/MasterExecutable.java PRE-CREATION > server/monitor/pom.xml ba61aeb > server/monitor/src/main/java/org/apache/accumulo/monitor/MonitorExecutable.java PRE-CREATION > server/tracer/pom.xml ac9f45f > server/tracer/src/main/java/org/apache/accumulo/tracer/TracerExecutable.java PRE-CREATION > server/tserver/pom.xml cd0f8ef > server/tserver/src/main/java/org/apache/accumulo/tserver/TServerExecutable.java PRE-CREATION > shell/pom.xml db3530f > shell/src/main/java/org/apache/accumulo/shell/Shell.java a64ff45 > start/src/main/java/org/apache/accumulo/start/Main.java c820883 > start/src/main/java/org/apache/accumulo/start/spi/KeywordExecutable.java PRE-CREATION > > Diff: https://reviews.apache.org/r/30382/diff/ > > > Testing > ------- > > > Thanks, > > Christopher Tubbs > > --===============8247715003085862390==--