Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B42B81756D for ; Thu, 29 Jan 2015 16:25:16 +0000 (UTC) Received: (qmail 17074 invoked by uid 500); 29 Jan 2015 16:25:17 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 17030 invoked by uid 500); 29 Jan 2015 16:25:17 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 16999 invoked by uid 99); 29 Jan 2015 16:25:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jan 2015 16:25:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8A7171D5D49; Thu, 29 Jan 2015 16:25:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4873822662898572423==" MIME-Version: 1.0 Subject: Re: Review Request 30417: ACCUMULO-3462 ACCUMULO-3541 fixed compaction logging and state bug From: keith@deenlo.com To: "Eric Newton" Cc: "accumulo" , keith@deenlo.com Date: Thu, 29 Jan 2015 16:25:09 -0000 Message-ID: <20150129162509.25679.16975@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: noreply@reviews.apache.org X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/30417/ X-Sender: noreply@reviews.apache.org References: <20150129155950.25680.51820@reviews.apache.org> In-Reply-To: <20150129155950.25680.51820@reviews.apache.org> Reply-To: keith@deenlo.com X-ReviewRequest-Repository: accumulo --===============4873822662898572423== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30417/#review70216 ----------------------------------------------------------- `mvn verify -Psunny` passed... going to look for some compaction specific ITs to run - kturner On Jan. 29, 2015, 3:59 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30417/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 3:59 p.m.) > > > Review request for accumulo and Eric Newton. > > > Bugs: ACCUMULO-3462 and ACCUMULO-3541 > https://issues.apache.org/jira/browse/ACCUMULO-3462 > https://issues.apache.org/jira/browse/ACCUMULO-3541 > > > Repository: accumulo > > > Description > ------- > > Fixes compaction logging bug and bug with compaction state not being reset. Patch builds on work already committed for ACCUMULO-3462. > > I am slightly nervous about the changes w/ control flow, but I feel this is the best solution to avoid duplicate logging. > > > Diffs > ----- > > server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 7420ec4 > > Diff: https://reviews.apache.org/r/30417/diff/ > > > Testing > ------- > > Still running ITs. Getting this patch out for review so we can move forward for 1.6.2. > > > Thanks, > > kturner > > --===============4873822662898572423==--