Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9FF8D17A54 for ; Mon, 26 Jan 2015 20:53:25 +0000 (UTC) Received: (qmail 38696 invoked by uid 500); 26 Jan 2015 20:53:26 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 38657 invoked by uid 500); 26 Jan 2015 20:53:25 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 38634 invoked by uid 99); 26 Jan 2015 20:53:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jan 2015 20:53:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 49A291D5FEA; Mon, 26 Jan 2015 20:53:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0030825920552652161==" MIME-Version: 1.0 Subject: Re: Review Request 30280: ACCUMULO-3533 Making AbstractInputFormat.getConfiguration() protected to match backwards compatibility with 1.6.1 From: "Josh Elser" To: "Eric Newton" , "Christopher Tubbs" , "Sean Busbey" , "Josh Elser" , keith@deenlo.com Cc: "accumulo" , "Corey Nolet" Date: Mon, 26 Jan 2015 20:53:21 -0000 Message-ID: <20150126205321.25680.69865@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Josh Elser" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/30280/ X-Sender: "Josh Elser" References: <20150126190411.25679.7070@reviews.apache.org> In-Reply-To: <20150126190411.25679.7070@reviews.apache.org> Reply-To: "Josh Elser" X-ReviewRequest-Repository: accumulo --===============0030825920552652161== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30280/#review69674 ----------------------------------------------------------- Ship it! Ship It! - Josh Elser On Jan. 26, 2015, 7:04 p.m., Corey Nolet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30280/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 7:04 p.m.) > > > Review request for accumulo, Sean Busbey, Christopher Tubbs, Eric Newton, Josh Elser, and kturner. > > > Bugs: ACCUMULO-3533 > https://issues.apache.org/jira/browse/ACCUMULO-3533 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-3533 Moving the getConfiguration logic which uses reflection to guarantee Hadoop 1 & 2 compatiblity to its own util class outside of the public API. Making the AbstractInputFormat.getConfiguration() protected once again. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java bcbfddc > core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java c68dd56 > core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java 010a94f > core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 0f495f0 > core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java a60cb80 > core/src/main/java/org/apache/accumulo/core/util/HadoopCompatUtil.java PRE-CREATION > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java 1b8cbaf > > Diff: https://reviews.apache.org/r/30280/diff/ > > > Testing > ------- > > Basic build with unit tests. > > > Thanks, > > Corey Nolet > > --===============0030825920552652161==--