accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 30417: ACCUMULO-3462 ACCUMULO-3541 fixed compaction logging and state bug
Date Thu, 29 Jan 2015 19:57:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30417/
-----------------------------------------------------------

(Updated Jan. 29, 2015, 7:57 p.m.)


Review request for accumulo and Eric Newton.


Changes
-------

Go from 2 to 1 `try{}finally{}` blocks in `majorCompact()`.


Bugs: ACCUMULO-3462 and ACCUMULO-3541
    https://issues.apache.org/jira/browse/ACCUMULO-3462
    https://issues.apache.org/jira/browse/ACCUMULO-3541


Repository: accumulo


Description
-------

Fixes compaction logging bug and bug with compaction state not being reset.  Patch builds
on work already committed for ACCUMULO-3462.

I am slightly nervous about the changes w/ control flow, but I feel this is the best solution
to avoid duplicate logging.


Diffs (updated)
-----

  server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 7420ec4 

Diff: https://reviews.apache.org/r/30417/diff/


Testing
-------

Still running ITs.  Getting this patch out for review so we can move forward for 1.6.2.


Thanks,

kturner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message