accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration info to user manual and log error when improperly configuring instance.volumes.
Date Tue, 20 Jan 2015 06:07:45 GMT


> On Jan. 17, 2015, 1:08 a.m., Sean Busbey wrote:
> > docs/src/main/latex/accumulo_user_manual/chapters/administration.tex, line 584
> > <https://reviews.apache.org/r/29959/diff/3/?file=823376#file823376line584>
> >
> >     nit: you should say what an operator should expect to see from this command
when it's successful (nothing, IIRC) and maybe what it says if it fails.
> 
> Corey Nolet wrote:
>     I was going to add a log statement so that the user could get some feedback but then
I came across line 294 in the Initialize class. Were you at least able to see the "Added volume
<volume>" log statement? Were you looking for something more descriptive?

When I ran through the instructions (which was back on 1.6.0), nothing was output to the console.
I didn't go digging into logs though.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68522
-----------------------------------------------------------


On Jan. 19, 2015, 6 p.m., Corey Nolet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 6 p.m.)
> 
> 
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as
an error message when a replaced instance appears in instance.volumes
> 
> 
> Diffs
> -----
> 
>   docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1 
>   server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797 
> 
> Diff: https://reviews.apache.org/r/29959/diff/
> 
> 
> Testing
> -------
> 
> Built the manual and found that the page numbers aren't aligning with the table of contents.
Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's
been around for awhile.
> 
> Physically tested the error message appears when 'bin/accumulo init --add-volumes' is
called and a replaced volume appears in instance.volumes. Also verified that the error does
not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not
appear in instance.volumes
> 
> 
> Thanks,
> 
> Corey Nolet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message